Skip to content

Preview providers should take maxX and maxY into consideration #13607

@oparoz

Description

@oparoz

Problem

The interface includes maX and maxY for a reason and yet, none of the providers use it.

A 5000x5000, 140MB TIFF is currently being converted to a 5000x5000 50MB PNG.
Fortunately, it will soon be possible to avoid multiple roundtrips to ImageMagick (via #13674) , but each resizing request of that 50MB PNG is still going to take some time (and waste memory) and that will only partially be fixed once #8196 is implemented.

Solution

Make sure preview providers take maxX and maxY into consideration when generating previews. With #13674 in place, each provider should only be called once.

I'm going to fix Bitmap, but the other providers should be fixed as well.

  • Bitmap
  • Image
  • Txt
  • MP3
  • SVG
  • Movie

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions