[7.0.2] [external_files::AmazonS3] SignatureDoesNotMatch when enabling SSL with bucket name includes dot

[dotme-takase]

Hi, I'm using Amazon S3 and my bucket name includes dot (e.g. my.bucket).
I tried to add external storage mounts my S3 bucket.

Non-SSL works fine, but when I checked 'Enable SSL', mounting fails and icon turned to red.
Because I thought this caused by sub-subdomain problem, I set 'Hostname' in s3's default hostname with region like 's3-ap-northeast-1.amazonaws.com'.

But when the hostname includes region, S3Client couldn't find current directory, and [file_exists('.')] test fails.

So I modified function 'cleanKey' in /apps/files_external/lib/amazons3.php for workaround.

        private function cleanKey($path) {
                if ($path === '.') {
                        return ''; //workaround
                }
                return $path;
        }

Isn't there any other good solution?

[schiessle]

@butonic any idea what could be wrong here?

[butonic]

@schiesbn While s3 does allow you to add directory objects it does not update their mtime when a child changes. Even worse you cannot treat the root folder like a directory. With the the cleanKey method we tried to make directory operations for the root folder work. It turned out as garbage. S3 is currently under heavy bugfixing: #10104 has been merged, #11375 awaits review and I will add #10508 to it after testing it locally. would be awesome if you could be the second reviewer.

@dotme-takase you could try with the stable7 branch. It fixes a lot of problems. We are tuning performance and ssl problems with the above mentioned PRs..

[dotme-takase]

Thank you for quick response !
I'll try it.

[butonic]

@dotme-takase any luck?

[butonic]

fix will be in next build of master and stable7

[dotme-takase]

@butonic I'm very sorry for late response.
I was busy with other issues, and I couldn't try it soon.

I tried stable7 today. It works very well,
now I can connect to S3 bucket contains preriod with SSL.

Thank you.

[butonic]

@dotme-takase no hard feelings. Glad it is working for you!

[butonic]

Oh and open a new issue for the bucket with period issue ...