Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve poll-interval comments #9465

Merged
merged 4 commits into from
Feb 23, 2022
Merged

Improve poll-interval comments #9465

merged 4 commits into from
Feb 23, 2022

Conversation

phil-davis
Copy link
Contributor

PR #8777 made the client responsive to the "pollinterval" setting reporting by the server in the capabilities.

The value of pollintervalis now interpreted as milliseconds.

This PR clarifies some comments. Hopefully I have made it clearer for future readers.

@phil-davis phil-davis self-assigned this Feb 22, 2022
@phil-davis phil-davis mentioned this pull request Feb 22, 2022
Merged
fmoc
fmoc reviewed Feb 22, 2022
View reviewed changes
src/libsync/configfile.cpp Outdated Show resolved Hide resolved
@phil-davis phil-davis requested a review from fmoc February 23, 2022 02:21
@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10858/5/1
💥 The GUI tests failed.
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10858/guiReportUpload/index.html)
Server Logs: ((https://cache.owncloud.com/public/owncloud/client/10858/guiReportUpload/serverlog.log)

TheOneRing
TheOneRing reviewed Feb 23, 2022
View reviewed changes
src/gui/folderman.cpp Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@phil-davis phil-davis changed the base branch from master to 2.10 February 23, 2022 09:51
@owncloud owncloud deleted a comment from ownclouders Feb 23, 2022
@owncloud owncloud deleted a comment from ownclouders Feb 23, 2022
@ownclouders
Copy link
Contributor

Results for GUI-tests https://drone.owncloud.com/owncloud/client/10865/5/1
💥 The GUI tests failed.
GUI Logs: (https://cache.owncloud.com/public/owncloud/client/10865/guiReportUpload/index.html)
Server Logs: ((https://cache.owncloud.com/public/owncloud/client/10865/guiReportUpload/serverlog.log)

@TheOneRing
Copy link
Member

I added a missing namespace.

@sonarcloud
Copy link

sonarcloud bot commented Feb 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@phil-davis
Copy link
Contributor Author

IMO this is ready for review. Someone please review, approve and it can be merged.

@TheOneRing
Copy link
Member

thx

@TheOneRing TheOneRing merged commit a34a42e into 2.10 Feb 23, 2022
@delete-merged-branch delete-merged-branch bot deleted the improve-poll-interval-comments branch February 23, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstingl michaelstingl Awaiting requested review from michaelstingl

@dragotin dragotin Awaiting requested review from dragotin

@mmattel mmattel Awaiting requested review from mmattel

@fmoc fmoc Awaiting requested review from fmoc

@TheOneRing TheOneRing Awaiting requested review from TheOneRing

Assignees

@phil-davis phil-davis

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@phil-davis @ownclouders @CLAassistant @TheOneRing @fmoc