-
Notifications
You must be signed in to change notification settings - Fork 683
Use server capabilities #3439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use server capabilities #3439
Conversation
If the server admin has enforced the expiration date and the password our UI should not give the user the option to remove those.
|
Two questions/suggestions:
What do you think? |
I agree. Now the questions is where and how to do this. Do we do this on a as needed basis... so I create a shareCapabilities class where all that is properly parsed. Or do we do it in 1 place where we parse everything?
Yes, this should be changed indeed. |
|
@dragotin both your comments are address in the latest two commits... |
src/libsync/account.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not be a pointer. Just make it a normal object like the QVariantMap was.
|
@ogoffart thanks and fixed! |
src/libsync/capabilities.h
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks wrong, you are not assinging anything.
The default generated copy constructor and operator are fine. Implementing them breaks the move sementic. (see "Rule of zero")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaah you are right...
Use server capabilities for share dialog
Replaces #2943
Should fix: #2815
By making use of the capabilities provided by the server we can provide a better UX.