[DC-217] implement the folder item delegate #12456
Draft
Conversation
having problems with the space image so for now just using app image for folder icon. this is quite rough still but need to pull the menu changes from master, so be it
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
… uses larger font for the folder name, has better calcs for sizeHint and all that jazz. I also incorporated the folderitemupdater into the folderitem directly - not sure if this permanent but it does work to eg, update the status icon when folder status changes
added a connection to the progress updates which is only connected during sync. this seems to have reduced the number of updates which seem to be triggered just because discovery finished in which case totals = 0 (as there is nothing to do). I think this can be further refined but for now this is a good start to make sure users can see general progress during large syncs. With small syncs the state changes so fast you never see the info - it just appears as a blip so nothing to see even if we could give more info
simple sort added (same as old but simpler impl) added correct ctr and inheritance to FolderErrorItem (impl next) deleted some useless stuff
make sure we don't allow multi-select auto-select newly added folder
so far I have a separate item delegate to handle the folder options button and that is working pretty well. the current problem is that the column sizes are wrong. I spent a ridiculous amount of time trying to get the first column to stretch but for reasons I don't understand, the logical indexes dont seem to be available no matter where I call setSectionResizeMode(index, Stretch) and it crashes on that call. Next try will use a listener on the header to wait for the sections to be added, then hopefully I can correctly set the resize mode per column using the logical indexes at that stage. This is really weird overall though. Never had such problems with column sizes in the past.
fixed the column/button delegate sizing issue refresh the menu before show a bit of cleanup
fixed the highlight color on selected rows added accessible text and description to item in button column deleted some dead stuff fixed missing item when connection is lost or restored added a new string to cover the "NotYetStarted" sync state as restoring a disabled space was weird without that.
…into refactor/DC-217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-217