[DC-205] refactor: consolidate business logic for account folders into new controller #12407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
…> accountfoldersview also started moving some stuff from the accountview to the accountfolderscontroller - these are disabled at the moment as they need work
…y taken from the drive. the drive() accessor is now removed, dependents are updated. also added new notifications on refreshing spaces to cover various flavors of space(s)Added and removed. I am not sure which of these will be useful yet but put the notifications in now to get a feel for the options. most impactful change: the space now returns a bool for setDrive which will indicate if the space changed or not after the periodic drive update(every 30 seconds). For now keep the spaceChanged notification in the spaces manager but only emit if it *actually* changed. at the moment this is based just on whether the etag changed, if there are individual props that don't trigger an etag change I will deal with them later.
…lect the real purpose of the param = sortPriority
I changed the structure for the _folders so it's easier to target lookups by acccount id and/or spaceid (for a folder) also fixed a couple of missed opportunities from the last refactoring of the class updated dependents adjusted signals from spacesmanager to include account id
…ally supposed to work - I reverted the single change I made to this function but on windows at least, I still had to comment out two validations. these tests in particular need deep review and update wrt the use of "dead" OC10SyncRoot, questionable uuid vals, and lack of clarity on what the expected results are
… "broken" tests work. adding a todo to review all this stuff as it's not the first time the test assumptions were woefully lacking.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-205