Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install Defaults and Sync size for Desktop Install Wizard #2580

Closed
MTRichards opened this issue Dec 4, 2014 · 20 comments
Closed

Install Defaults and Sync size for Desktop Install Wizard #2580

MTRichards opened this issue Dec 4, 2014 · 20 comments
Assignees
Labels
p2-high Escalation, on top of current planning, release blocker

Comments

@MTRichards
Copy link

As a user of ownCloud, I would like to have the default selection "choose what I sync" when I install the client so that I don't start syncing 11GB (for example) of data to my desktop via external storage by default.

Acceptance Criteria:

  • Have the default be "choose what I sync" (today it is sync everything)
  • Have the total size and available disk size of the sync everything result be displayed for this user next to the "sync everything" with the heading "This will use XGB of your remaining YGB of free space".

@dragotin

@danimo
Copy link
Contributor

danimo commented Dec 4, 2014

@MTRichards is YGB of free space referring to the available disk space at the projected location of the local sync folder?

@MTRichards
Copy link
Author

Yes! So someone can see - hey, I can't sync all or it will overload my hard drive!

@dragotin dragotin added this to the 1.8 - UI Enhancements milestone Jan 9, 2015
@dragotin dragotin added the p2-high Escalation, on top of current planning, release blocker label Jan 9, 2015
@dragotin
Copy link
Contributor

@DeepDiver1975 we need your help! A PROPFIND on a dir returns the entry

DAV: quota-used-bytes = 8223121

That is the size of the dir, magically computed recursively, awesome stuff.

But how does that work with a shared dir? Can you confirm that it calculates the data size of the shared contents? That is important for this feature, and I remember there have been discussions about this.

@ogoffart
Copy link
Contributor

The size is now shown (using the quota-used-bytes reported from the server)

@ogoffart
Copy link
Contributor

So how do we know what is supposed to be sync'ed and what is no supposed to be sync'ed?

@dragotin
Copy link
Contributor

@ogoffart In a mail about this @MTRichards says:
"So, to solve this - what I propose here is a branded client option. A switch that allows the setup wizard to generate either: sync everything by default, or sync nothing."

In a second chapter, @MTRichards says:
"When a customer is already syncing, if a large directory is added - then that will sync automatically. This same issue I intend to fix with shared directory warnings "Do you want to accept the share", then it will sync but at least people will know a new root folder is added."
However I am not sure if that means that we should require user interaction to accept a new top level dir if it is large.

Maybe rather these two things:

  • If we detect in the update phase that a new top level dir is larger than lets say 200 MB we do not include it to the sync but set it to not selected in selective sync.
  • If we sync a new toplevel dir we show a notification saying "A new toplevel dir with size of xx MB was added to the sync", or, we add a size information to our already existing notification.

@ogoffart
Copy link
Contributor

The sync behaviour after the wizard is part of another issue ( #2707 )

So then would the theme (branding) contains a flag to unselect everything in the selective sync dialog? and preselect that option?

@MTRichards
Copy link
Author

Right - there are two problems:

  1. initial setup - syncing everything by default (click, click, click user behavior) - we want them to have to think before accepting to sync everything - particularly when it will fill the local disk
  2. after initial setup - these are a good idea:

If we detect in the update phase that a new top level dir is larger than lets say 200 MB we do not include it to the sync but set it to not selected in selective sync.
If we sync a new toplevel dir we show a notification saying "A new toplevel dir with size of xx MB was added to the sync", or, we add a size information to our already existing notification.

@MTRichards
Copy link
Author

@ogoffart that is the short term fix that has been requested, yes. To be able to have the default installer not sync everything by default on initial setup.

ogoffart added a commit that referenced this issue Jan 22, 2015
@ogoffart
Copy link
Contributor

So i added Theme::wizardSelectiveSyncDefaultNothing. Which theme do need this setting?

@ogoffart ogoffart added the ReadyToTest QA, please validate the fix/enhancement label Jan 22, 2015
@ogoffart
Copy link
Contributor

This can be tested using the testpilot theme.

@luciamaestro
Copy link

@ogoffart In version1.8.0-nightly20150126 (build 1941) the option "choose what I sync" is not the default option.

@ogoffart
Copy link
Contributor

It is only the default in theme that have this option such as the testpilot theme

@luciamaestro
Copy link

Waiting to a testpilot build to verify that the "choose what to sync" is the option by default.

@luciamaestro luciamaestro removed the ReadyToTest QA, please validate the fix/enhancement label Jan 27, 2015
@luciamaestro
Copy link

@danimo Can you provide me the test build?

@danimo
Copy link
Contributor

danimo commented Feb 4, 2015

Working on it

@luciamaestro
Copy link

I tested testpilot theme and now when you launch the app after introduce the server and credentials, the pop-up of "Choose what to sync" opens but if you close it, the option chosen is "Sync everything from the server". Maybe the option by default when the pop-up is closed should be "Choose what to sync".

Also the pop said "Unchecked folder will be removed from your local...." and by default all the folder are unchecked. This message should be changed.

ogoffart added a commit that referenced this issue Feb 5, 2015
Have different wording depending on the wizardSelectiveSyncDefaultNothing theme option

Relates to #2580
@ogoffart
Copy link
Contributor

ogoffart commented Feb 5, 2015

I change the wording.
It now reads: Choose What to Sync: Select remote subfolders you wish to synchronize. in this configuration.

But if you cancel that dialog, then it will sync everything because if you cancel the choose what to sync dialog it means everything is selected.

@luciamaestro
Copy link

Now the message is :
screen shot 2015-02-05 at 6 03 39 pm

In my opinion this feature is closed, if anyone don't think so, please reopen it.

@ogoffart
Copy link
Contributor

ogoffart commented Feb 6, 2015

Another option could have been to set a default remote folder in the theme (eg. syncclient/ ) And if the user wants to add a sharepoint folder he can add it using the add folder feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p2-high Escalation, on top of current planning, release blocker
Projects
None yet
Development

No branches or pull requests

5 participants