Skip to content

Conversation

@hannesa2
Copy link
Contributor

@hannesa2 hannesa2 commented Jan 4, 2020

image

@jesmrec
Copy link
Collaborator

jesmrec commented Jan 8, 2020

Any other clue about the problem? is it reproducible? which steps?

Also, it'd be appreciated more descriptive names in the issues and PRs, and therefore in the branches' names. For the branching we are using the Oneflow way: https://www.endoflineblog.com/oneflow-a-git-branching-model-and-workflow#the-main-branch.

with prefixes feature\ , fix\ , release\ and test\ (i think i do not miss any other one)

I'll check if this is included in the contributing documents, in order to clarify it. Thanks for your contribution!

@hannesa2
Copy link
Contributor Author

hannesa2 commented Jan 8, 2020

It happened during mark a folder "offline available".

For the branch name: ok, I will do

@hannesa2 hannesa2 mentioned this pull request Jan 24, 2020
@jesmrec jesmrec added this to the 2.15 milestone Feb 3, 2020
@davigonz
Copy link
Contributor

davigonz commented Feb 4, 2020

@jesmrec code approved, ready to test (if needed)

@jesmrec
Copy link
Collaborator

jesmrec commented Feb 5, 2020

Yes, i managed to create some available offline over populated folders. everything OK on my side.

@davigonz davigonz merged commit 7eace81 into master Feb 6, 2020
@davigonz davigonz deleted the fixNPE branch February 6, 2020 08:13
@jesmrec jesmrec removed the Sprint label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants