Better logging GUI

[hannesa2]

It's about to change logging from self-made to Timber.
This PR is the GUI part from owncloud/android-library#275 and it relies on it.

It removes the logic to display log and simply uses a Fragment from logging-lib.

It keeps all previous functions like

• searching

and adds

• a tab for ownCloud Filelogging view
• a tab for Logcat view
  • to see what happens on other processes too
  • to log what ownCloud forgot to log
  • within release build type !
• share log
• adds filter for Verbose, Debug, Info, Warning, Error

Eg, when you select Info you will see only Info, Warning, Error entries and filters out Verbose, Debug

So it helps to investigate, what's wrong with ownCloud.

Btw, I recommend to add Firebase Crashlytics in ownCloud. If you want, I can help you with this task

[hannesa2]

I found an issue

[michaelstingl]

Timber's Apache License 2.0 would work 👍

[hannesa2]

Timber's Apache License 2.0 would work 👍

fulfilled

https://github.com/JakeWharton/timber/blob/f6d1b98d6280ec567d4e8b60a011f662fdce445b/LICENSE.txt#L2-L3

[abelgardep]

I have been testing this and looks good, but i found some problems.

1. If you don't have permissions, it gets some errors, maybe it should check if it has access before start logging to a file.
   

2. I got an error trying to share [FIXED]
   2019-11-11 08:41:46.953 16372-16372/com.owncloud.android.debug E/(LogBaseFragment.kt:203) .sendLogContent(): java.lang.NoSuchFieldException: mail_logger

3. I got also some
   2019-11-11 08:41:31.522 16372-16372/com.owncloud.android.debug E/RecyclerView: No adapter attached; skipping layout

Pixel 2 v10

[abelgardep]

Btw, I recommend to add Firebase Crashlytics in ownCloud. If you want, I can help you with this task

This could be interesting. You can create an issue to discuss it there 👍

[davigonz]

Btw, I recommend to add Firebase Crashlytics in ownCloud. If you want, I can help you with this task

We're wondering if the integration of ownCloud with this sort of third-party solutions could trigger privacy issues, you know, my ownCloud, my info. We pay much attention to the info we put in the logs but is something to consider anyway, what do you think @michaelstingl ?

[abelgardep]

Some changes requested @hannesa2 👍

[abelgardep]

Could you include this as constants?

[abelgardep]

Sorry, I meant hardcoded strings

[michaelstingl]

We're wondering if the integration of ownCloud with this sort of third-party solutions could trigger privacy issues, you know, my ownCloud, my info. We pay much attention to the info we put in the logs but is something to consider anyway, what do you think @michaelstingl ?

Is this SaaS only? Or can we host this ourself? Better open new issue for discussion, and we also should involve @theScrabi – I remember he also proposed a solution.

[hannesa2]

One alternative could be https://github.com/Countly I only know the Android part, it's very similar to Firebase. At least, there is a server in GitHub too

[hannesa2]

continue here #2725

[hannesa2]

I have been testing this and looks good, but i found some problems.

1. If you don't have permissions, it gets some errors, maybe it should check if it has access before start logging to a file.
   ![Screenshot 2019-11-11 at 08 40 20](https://user-images.githubusercontent.com/47524927/68570252-800e1700-0460-11ea-97b3-0b9d537f848a.png)

2. I got an error trying to share [FIXED]
   `2019-11-11 08:41:46.953 16372-16372/com.owncloud.android.debug E/(LogBaseFragment.kt:203) .sendLogContent(): java.lang.NoSuchFieldException: mail_logger `

3. I got also some
   `2019-11-11 08:41:31.522 16372-16372/com.owncloud.android.debug E/RecyclerView: No adapter attached; skipping layout `

Pixel 2 v10

1. It's because you show File Activity with write-permission request there, and create on top the login screen. That's why, the user has no chance to accept permission and you start to log immediate. This is only in debug, on release, the pro-user ! has before to enable developer menu and it will not happen in release.
   I want to avoid a permission check on every log entry. This is not performant
2. solved
3. solved