[FEATURE REQUEST] Add "Sync now" at automatic photos upload

[MJ-sys]

Is your feature request related to a problem? Please describe.
Sometimes I am connected with a slow wifi connection so I had to disable OC running in background otherwise after connecting to the network it starts to sync photos. While syncing, the network is impossible to use.

Describe the solution you'd like
It would be helpful for me to completely disable "running in background" (for example with checkbox in settings tab) and add button "sync now" to the upload tab.

Additional context
Currently, it is not very user-friendly for me. When I disabled running in background and I want to sync my photos, I have to wait some time with display on to start syncing. A simple button would help me.

TASKS

• Add checkbox "running in background" to the settings tab
• Add button "Sync now" to the upload tab (show only when running in background is disabled)

[jesmrec]

The following community PR is related: #2772

waiting for fixing some issues there.

[hannesa2]

The following community PR is related: #2772

waiting for fixing some issues there.

@jesmrec
I see two questions there and an answer #2772 (comment)

But I guess there is some communication friction. Please make exact requirements.
And handle with care, this function has a huge ability of miss usage.

[jesmrec]

And handle with care, this function has a huge ability of miss usage.

for that reason i'm skeptic with the feature.

Actually:

• It is possible to decide to upload automatically either photos or videos
• JobScheduler is triggered after every 15 minutes to upload all the new content.

Both together should be enough to perform a good auto uploading feature. But, i get the point of @MJ-sys and sometimes, depending on the quality of your connection it could be better to force it manually. In that case, they will not be "auto" upload anymore. Do we want this?

Or... do we want both? every 15 minutes the JobScheduler working, and additionally, the button to force the sync? (how feasible is it this?)

This is not the same as setting a date from which you upload the content of your camera, losing the sense of the current implementation in which the starting date is the date in which you enable the feature or the last sync date to avoid repetitions. (do we want to lose this?)

In any case, in our next milestone it is scheduled to re-arquitect al the sync engine according Android Components. I agree that the requirements should be clear and accurate.

CC @michaelstingl @abelgardep

[MJ-sys]

From my point of view (I don't know the architecture of the app) it shouldn't be problematic so much. My two check-items could be rewritten in the programmer's language (probably) this way:

1. enable/disable JobScheduler - it doesn't matter if the whole service will be down or if it checks every 15 minutes if is enabled (and then do the job as today) or not (sleep again)
2. call the function tryToUploadWhatWasNotSentYet (sorry, don't know the exact name) which is called by the JobScheduler every 15 minutes

The calendar thing could be only extended function of "enable/disable". In other words - enable again at a specific time.

Sorry if I'm completely wrong due to misunderstanding the current project structure.

[hannesa2]

2. call the function tryToUploadWhatWasNotSentYet (sorry, don't know the exact name) which is called by the JobScheduler every 15 minutes

Attention !
We mix here two things.

A This tryToUploadWhatWasNotSentYet is one thing. And it's important to know, it stores the last start timestamp . If a sync is done, it's changed to the present, and so on ....

B #2772 it changes (only once) this stored timestamp to the past, because there were that much errors in sync, that my phone don't synced almost for two years.
#2772 is about to include missed files

Btw, I solved my problem already, I just want you participate with this function. If it will be never merged, I'm fine too