Reduce space used by OBO Parser #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(a) replace ArrayLists of size 0 with emptyList() (b) replace ArrayLists of size 1 with singletonList() (c) call trimToSize on ArrayLists of size >1. Modifications automatically the relevant objects. Add freezeFrames method to OBODoc, which will call freeze on all held frames.
…o 8K chars. Cached values are looked up in getParseUntil(String,boolean) Call freeze on header frame, term frames, and typedef frames.
# Conflicts: # oboformat/src/main/java/org/obolibrary/oboformat/model/Clause.java
ignazio1977
added a commit
that referenced
this pull request
Aug 9, 2015
Reduce space used by OBO Parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement memory saving techniques for oboformat objects. These changes help ameliorate the OOM issues involved in issue #426, but are not a complete fix, as the entire OBO document must be loaded into memory before conversion takes place.
Add freeze methods to oboformat Clause and Frame.
These methods:
Any Modifications automatically thaw the relevant objects.
Add freezeFrames method to OBODoc, which will call freeze on all held frames.
Add string cache to OBOFormatParser. Limit cache capacity to 8M chars.
Freeze frames during parsing.