App.Simple: Close App window before exiting #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gtk doesn't destroy its windows when `gtk_main_exit()` is called. It relies on the X server to DestroyAll resources when the app's connection to the X server is closed. This can result in zombie windows for programs which don't immediately exit after the Gtk main loop finishes. We solve it by explicitly destroying the window widget in response to the `Exit` transition. Also, for gtk_widget_destroy() to have any effect, the Gtk main loop needs to be still running. Thankfully, the `run` function provided by `GI.Gtk.Declarative.App.Simple` will ensure that is the case. Resolves owickstrom#105
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gtk doesn't destroy its windows when
gtk_main_exit()is called. It relies on the X server to DestroyAll resources when the app's connection to the X server is closed.This can result in zombie windows for programs which don't immediately exit after the Gtk main loop finishes.
We solve it by explicitly destroying the window widget in response to the
Exittransition.Also, for gtk_widget_destroy() to have any effect, the Gtk main loop needs to be still running. Thankfully, the
runfunction provided byGI.Gtk.Declarative.App.Simplewill ensure that is the case.Resolves #105