Fix 500 errors when missing theme CSS is requested #878
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been getting a few 500 errors when my CDN requests expired theme asset files. This is caused by
CamaleonController#render_error
looking for a template to render instead of just returning a 404 header. This pull request preserves existing behavior for HTML and returns a 404 status for other request types.This is not the only possible fix. If you'd prefer to only alter behavior for CSS, it can be done like this instead:
But I thought better to make the change for any request type that is not rendering an HTML page.
Yet another option would be to create a blank CSS file in the directory so there's something to render.