Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra plugin title in breadcrumbs #7

Merged
merged 1 commit into from
Aug 14, 2015
Merged

Remove extra plugin title in breadcrumbs #7

merged 1 commit into from
Aug 14, 2015

Conversation

cmckni3
Copy link
Contributor

@cmckni3 cmckni3 commented Aug 11, 2015

No description provided.

@cmckni3
Copy link
Contributor Author

cmckni3 commented Aug 12, 2015

@owen2345 Any possibility of looking at open Pull Requests? #5 #8

@owen2345
Copy link
Owner

Why delete plugin title?

@cmckni3
Copy link
Contributor Author

cmckni3 commented Aug 12, 2015

It shows up twice in the breadcrumbs. I believe it is added somewhere else but I can't find where.

owen2345 pushed a commit that referenced this pull request Aug 14, 2015
Remove extra plugin title in breadcrumbs
@owen2345 owen2345 merged commit 7940a72 into owen2345:master Aug 14, 2015
@owen2345
Copy link
Owner

Each plugin will need to add their breadcrumbs with:
admin_breadcrumb_add("My breadcrumb title", "the_url (optional)")

@cmckni3 cmckni3 deleted the patch-3 branch August 14, 2015 15:07
@cmckni3
Copy link
Contributor Author

cmckni3 commented Aug 14, 2015

Each plugin will need to add their breadcrumbs with:
admin_breadcrumb_add("My breadcrumb title", "the_url (optional)")

I'm not opposed to having plugins call admin_breadcrumb_add. It would allow finer controller.

On the other hand, we could modify the breadcrumb instance variable, @_admin_breadcrumb, to change the breadcrumbs. However, I don't like this since it requires knowledge of the implementation and structure of the instance variable.

owen2345 pushed a commit that referenced this pull request Oct 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants