parse only current fog dir #235 #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes browsing non-trivial s3 directories usable + reduces code complexity considerably
owen2345
added a commit
that referenced
this pull request
Dec 6, 2015
parse only current fog dir #235
|
Sweet @momolog thanks for this: actually I've tested it out and it seems to speed things up when trying to access the media page by hitting the index action on the controller; to be honest I think that it still needs some polishing around the edges because it looks like that now it hangs while trying to access the subfolders, anyway this is a definitive improvement 👍 |
|
@yortz It should work on subfolders as well (does for me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes browsing non-trivial s3 directories usable by only parsing the current directory and not alway building the whole tree.
It also reduces the code complexity of the media management.