fix syntax api_controller for Heroku

[Silvaire]

Error Stack on heroku:

[3] ! Unable to load application: SyntaxError: /app/vendor/bundle/ruby/2.1.0/gems/camaleon_cms-1.0.8/app/controllers/api/api_controller.rb:10: syntax error, unexpected ':', expecting =>
'userMessage': user_message,
^
/app/vendor/bundle/ruby/2.1.0/gems/camaleon_cms-1.0.8/app/controllers/api/api_controller.rb:11: syntax error, unexpected ':', expecting :: or '[' or '.'
'internalMessage': internal_message,
^
/app/vendor/bundle/ruby/2.1.0/gems/camaleon_cms-1.0.8/app/controllers/api/api_controller.rb:12: syntax error, unexpected ':', expecting :: or '[' or '.'
'code': code
^
/app/vendor/bundle/ruby/2.1.0/gems/activesupport-4.2.4/lib/active_support/dependencies.rb:274:in `require': /app/vendor/bundle/ruby/2.1.0/gems/camaleon_cms-1.0.8/app/controllers/api/api_controller.rb:10: syntax error, unexpected ':', expecting => (SyntaxError)
'userMessage': user_message,
^
/app/vendor/bundle/ruby/2.1.0/gems/camaleon_cms-1.0.8/app/controllers/api/api_controller.rb:11: syntax error, unexpected ':', expecting :: or '[' or '.'
'internalMessage': internal_message,
^
/app/vendor/bundle/ruby/2.1.0/gems/camaleon_cms-1.0.8/app/controllers/api/api_controller.rb:12: syntax error, unexpected ':', expecting :: or '[' or '.'
'code': code

[cmckni3]

This PR is unnecessary because this just converts to using Ruby 1.8 syntax. I fixed this in an earlier commit. You should update camaleon and deploy to heroku.

I fixed this in #171. See the commit for more information.

[Silvaire]

Alright, thank you for the info and sorry for the useless PR. I changed my Gemfile to point to https://github.com/owen2345/camaleon-cms and it works now. Because when fetching straight from rubygems, I still get this in app/controllers/api/api_controller.rb:

class Api::ApiController < CamaleonController
  #before_action -> { doorkeeper_authorize! :client }

  def account
    render json: current_user
  end

  def render_json_error(internal_message = 'Unexpected error', code = 100, status = 404, user_message = 'Unexpected error')
    error = {
        'userMessage': user_message,
    'internalMessage': internal_message,
    'code': code
    }
    render :json => error, :status => status
  end

  def render_json_ok(message = 'Success', status = 200, more_info = {})
    msg = {
        message: message,
        more_info: more_info
    }
    render :json => msg, :status => status
  end

end

[cmckni3]

Yeah for now you need to point to master or a commit on master because the ruby gems version is broken.

@owen2345 can you yank that release on ruby gems and add a new, good release?

[owen2345]

Hi @cmckni3 right now I will do it.

[owen2345]

Done!
I published the new gem version "1.0.9".

[cmckni3]

👍

Can you yank 1.0.8?

http://help.rubygems.org/kb/gemcutter/removing-a-published-rubygem

[Silvaire]

Actually, this PR also removed some (what I assume is debug) code in the sitemap method of app/controllers/concerns/frontend_concern.rb.

Could this be removed from the main repo? /sitemap.xml currently gives a 500, with undefined local variable or method 'a' for #<FrontendController>

[cmckni3]

Opened #199

[cmckni3]

Fixed by #199

/ping @owen2345

[cmckni3]

This should have been just closed but not a big deal.