Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert renaming to camelCase functions used in ERB - doesn't work #1044

Conversation

texpert
Copy link
Collaborator

@texpert texpert commented Mar 20, 2023

Live testing has revealed breakage after ESLint fixes - camelCase named JS functions are not working in ERB files.

@texpert texpert self-assigned this Mar 20, 2023
Copy link
Collaborator

@brian-kephart brian-kephart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine to me. Do all the other ESLint-related changes seem to work fine?

@texpert
Copy link
Collaborator Author

texpert commented Mar 22, 2023

The code looks fine to me. Do all the other ESLint-related changes seem to work fine?

I don't know about the others - these failures have appeared when I started testing creating a post with this branch. CamaInitPost not defined in browser's development console. Ditto when trying to updated the users.

Very weird that the feature specs are not failing...

I think we're not in a rush merging this branch, so it could be thoroughly tested.

@brian-kephart
Copy link
Collaborator

Very weird that the feature specs are not failing...

Yes, it's concerning that the spec didn't fail. We should definitely improve coverage, though I've been avoiding that since we talked about migrating the admin interface to new libraries and I didn't want to write tests that would have to be rewritten after that kind of change. We're going to have to decide just how much we're going to redo.

@texpert
Copy link
Collaborator Author

texpert commented Mar 22, 2023

Mmm, I am starting to think that we better increase the release cadence.

Camaleon being a pure OSS project, we bare have time to contribute on some weekends or holidays/vacations. So it will take forever to wait, for example for v.3 with all the targets completed. We'll get too far out of sync with our own code changes - I mean we'll simply forget some things :)

In every company that I've worked developers were not fond of big releases taking 3 to 6 months to prepare.

@texpert texpert merged commit c7d2429 into owen2345:feature/version-3 Mar 22, 2023
@texpert texpert deleted the revert-camel-case-naming-functions-used-in-erb branch November 12, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants