TinyMCE version 5 #1037
Merged
TinyMCE version 5 #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
texpert
approved these changes
Feb 1, 2023
|
@texpert I don't have any of the concerns you listed. I just want the assets to get digested properly so they can be properly expired if assets are served through a caching CDN. |
|
Also, I'm finding that the tinyMCE assets are not available in the dev environment using the |
|
Added a commit to fix #1038. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completes the upgrade of TinyMCE to v5, replacing #1035. It has been rebased on the v3 branch. One last consideration is whether the TinyMCE assets should be copied or compiled. We've switched it a couple of times. This PR chooses the compile option, but only because I did that for some reason when I first tried version 5 in 2020. It can be changed if needed.
For the next upgrade to v6, the tricky part is that the jQuery wrapper was removed from the gem, so we most likely have to change a bunch of code. We had discussed removing jQuery entirely and re-writing the frontend, so I'd like to hear ideas about that before diving into the next step.