Ruby 3.1 support #1010
Merged
Ruby 3.1 support #1010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a CI job for Ruby 3.1, which was released in preview today. Unfortunately, Github Actions hasn't added Ruby 3.1.0-preview1 yet, so the job doesn't pass CI yet. However, the spec passes locally in Ruby 3.1, and the ruby-head CI job passes as well (for the first time EVER, I think). So we have plenty of evidence that Camaleon will work just fine in Ruby 3.1.
The gems added to the gemspec are dependencies of the Mail gem. Ruby 3.1 still bundles these gems but no longer requires them by default, so for the first time they must be explicitly added. Presumably the Mail gem will receive an update at some point so that Camaleon no longer needs to include these gems in the gemspec.
Lastly, references to a deprecated Selenium exception are updated to get the tests passing.