Skip to content

Add capture action to @detectXSS operator #1488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add capture action to @detectXSS operator #1488

wants to merge 1 commit into from

Conversation

victorhora
Copy link
Contributor

@victorhora victorhora commented Jul 4, 2017

Proposed fix for #1482.

Do notice that the API for @detectXSS in libInjection is still in Alpha stage so there's some missing features when compared with @detectSQLi.

In this case, there's no "fingerprint" returned from libInjection API to be fed into a "capture" action to tell us exactly what triggered the match like it's done with libinjection_sqli

So this proposed "capture" action would fill TX.0 with the full analyzed parameter value (var->value) when libinjection_xss returns true.

@fgsch
Copy link

fgsch commented Jul 4, 2017

Is this any different to using MATCHED_VAR?

@victorhora
Copy link
Contributor Author

In this context, no @fgsch. But I'm not sure if there's much more we can do as the "API" looks limited in this aspect as of now.

But there's a chance I'm missing something, so let's see what others have to say :)

zimmerle pushed a commit that referenced this pull request Oct 5, 2017
@zimmerle
Copy link
Contributor

zimmerle commented Oct 5, 2017

Merged. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants