fix: Remove blocking for BEAM thread #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satoren
force-pushed
the
mshiraki/scheduler
branch
from
3a71961
to
297d23d
Compare
1 task
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
satoren
force-pushed
the
mshiraki/scheduler
branch
4 times, most recently
from
3dfbc5d
to
e68d817
Compare
Barecheck - Code coverage reportTotal: 100.00%Your code coverage diff: 0.00% ▴ ✅ All code changes are covered |
satoren
force-pushed
the
mshiraki/scheduler
branch
from
e68d817
to
fc8697c
Compare
satoren
force-pushed
the
mshiraki/scheduler
branch
from
fc8697c
to
f00133f
Compare
satoren
changed the title
darwin67
reviewed
Dec 6, 2021
| @@ -66,6 +67,40 @@ where | |||
| }); | |||
| } | |||
|
|
|||
| // workarounf for future created by async block is not `Send` at send_async_nif_result | |||
| pub fn async_nif_thread_spawn<T, E, Fn, Fut>(env: Env, future: Fn) -> NifResult<(Atom, Atom)> | |||
There was a problem hiding this comment.
ah i see. you're defining your own future to handle Send + Sync.
There was a problem hiding this comment.
versatica/mediasoup#729
This fix has been merged and I can remove this workaround later.
darwin67
approved these changes
Dec 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://ovice.atlassian.net/browse/APP-518
rusterlium/rustler#409