Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow specifying query parameters #629

Merged
merged 4 commits into from
May 4, 2023
Merged

feat: allow specifying query parameters #629

merged 4 commits into from
May 4, 2023

Conversation

guoweis-work
Copy link
Contributor

@guoweis-work guoweis-work commented Feb 10, 2023

This allows specifying the query parameters and properly encode them.

This is for issue #625

Copy link
Member

@yesnault yesnault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @guoweis-outreach , thank you for this PR.

Can you add documentation on http/README.md file, and unit test and/or tests into tests/ directory about that please?

Thank you

@ovh-cds
Copy link
Collaborator

ovh-cds commented Feb 15, 2023

CDS Report build-venom-a#1086.0 ✘

  • Build
    • Build ✔
    • Unit Tests ✔
  • Tests
    • Acceptance Tests ✘

@guoweis-work
Copy link
Contributor Author

@yesnault i'm not sure how to run Acceptance Tests or where to find the log why Acceptance Tests failed. Any tips?

@ovh ovh deleted a comment from ovh-cds May 3, 2023
@ovh ovh deleted a comment from ovh-cds May 3, 2023
tests/http.yml Outdated Show resolved Hide resolved
guowei shieh and others added 4 commits May 4, 2023 10:33
Signed-off-by: guowei shieh <guowei.shieh@outreach.io>
Signed-off-by: guowei shieh <guowei.shieh@outreach.io>
Signed-off-by: Guo-wei Shieh <guowei.shieh@outreach.io>
@ovh-cds
Copy link
Collaborator

ovh-cds commented May 4, 2023

CDS Report build-venom-a#43.0 ✘

  • Build
    • Build ✔
    • Unit Tests ✔
  • Tests
    • Acceptance Tests ✘

@yesnault yesnault merged commit 5b6a4bb into ovh:master May 4, 2023
ivan-velasco pushed a commit to socotra/venom that referenced this pull request Sep 20, 2023
* feat: allow specifying query parameters

Signed-off-by: guowei shieh <guowei.shieh@outreach.io>
Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants