-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow specifying query parameters #629
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @guoweis-outreach , thank you for this PR.
Can you add documentation on http/README.md file, and unit test and/or tests into tests/ directory about that please?
Thank you
CDS Report build-venom-a#1086.0 ✘
|
@yesnault i'm not sure how to run |
Signed-off-by: guowei shieh <guowei.shieh@outreach.io>
CDS Report build-venom-a#43.0 ✘
|
* feat: allow specifying query parameters Signed-off-by: guowei shieh <guowei.shieh@outreach.io> Signed-off-by: Ivan Velasco <ivan.velasco@socotra.com>
This allows specifying the query parameters and properly encode them.
This is for issue #625