feat: skip support at step level
#592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: GitHub <noreply@github.com>
lowlighter
commented
Oct 17, 2022
| @@ -302,24 +302,31 @@ func (v *Venom) runTestSteps(ctx context.Context, tc *TestCase, tsIn *TestStepRe | |||
| printStepName := v.Verbose >= 1 && !fromUserExecutor | |||
| v.setTestStepName(tsResult, e, step, &ranged, &rangedData, rangedIndex, printStepName) | |||
|
|
|||
There was a problem hiding this comment.
Diff below looks complicated but it actually just move all the code related to v.RunTestStep to the else block of the if skip conditional
lowlighter
commented
Oct 17, 2022
process_testsuite.go
Outdated
| for _, testStepResult := range tc.TestStepResults { | ||
| if testStepResult.RangedEnable { | ||
| hasRanged = true | ||
| } | ||
| if testStepResult.Status == StatusFail { | ||
| hasFailure = true | ||
| } | ||
| if testStepResult.Status == StatusSkip { | ||
| skippedSteps++ | ||
| } | ||
| } | ||
|
|
||
| if verboseReport || hasRanged { |
There was a problem hiding this comment.
Not sure if it's because of my environment, but the newline seems to be printed too late when I run venom in verbose mode:
In my tests I moved this block to line 114 (just before v.runTestCase(ctx, ts, tc)) and it seems to yield the correct output.
Since the output from #583 (comment) looked correct, I didn't touched it, but just wanted to make a note about it
Signed-off-by: GitHub <noreply@github.com>
|
Kudos, SonarCloud Quality Gate passed! |
fsamin
approved these changes
Oct 18, 2022
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
yesnault
approved these changes
Oct 18, 2022
process_testsuite.go
Outdated
| for _, testStepResult := range tc.TestStepResults { | ||
| if testStepResult.RangedEnable { | ||
| hasRanged = true | ||
| } | ||
| if testStepResult.Status == StatusFail { | ||
| hasFailure = true | ||
| } | ||
| if testStepResult.Status == StatusSkip { | ||
| skippedSteps++ | ||
| } | ||
| } | ||
|
|
||
| if verboseReport || hasRanged { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #486
Make it possible to
skipat step level (currently it's only possible to do so at case level)If all steps from a case are skipped, then the case will also change its state to "SKIP" rather than "PASS"
Default output:
Verbose output:
Additionally this slightly changes the output of skipped test case when verbose mode is enabled to display that "all steps were skipped" rather than nothing, which could be misleading as a user may think that something is wrong with their test case definition
Current output