Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : set desired_nodes without max_nodes and min_nodes #538

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

atnbrg
Copy link
Contributor

@atnbrg atnbrg commented Jan 16, 2024

Description

When you want to create a nodepool, if you don't specify the max_nodes parameter, it is set to "0".
When you call the nodepool creation, the desired_nodes can not be greater than the max_nodes, and so it is set to "0".
The nodepool is created with 0 node.
The payload of the request must contain only the parameters specify in the hcl nodepool resource.

Fixes #485 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc TESTARGS="-run TestAccCloudProjectKubeNodePoolRessource"
  • Test A: make testacc TESTARGS="-run TestAccCloudProjectKubeNodePool"

Test Configuration:

  • Terraform version: terraform version: Terraform v1.6.6

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes

@atnbrg atnbrg marked this pull request as ready for review January 16, 2024 11:04
@atnbrg
Copy link
Contributor Author

atnbrg commented Jan 17, 2024

Can you review this pull request ?

@atnbrg atnbrg force-pushed the fix/485 branch 2 times, most recently from fd69e16 to e406dfc Compare January 18, 2024 08:52
@amstuta amstuta merged commit f6837fb into ovh:master Jan 18, 2024
@atnbrg atnbrg deleted the fix/485 branch February 1, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] desired_nodes is not propageted to the nodepool
2 participants