Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): fix s3 credentials secret retrieval #492

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

reenjii
Copy link
Contributor

@reenjii reenjii commented Nov 9, 2023

Description

Fix the security update that removes S3 secret key from GET calls in OVH API.

Fixes #490

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

It has been tested to retrieve a user and check that the secret is properly returned.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 9, 2023

CDS Report terraform-provider-ovh-check#2151.0 ✔
*

  • checks ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 9, 2023

CDS Report terraform-provider-ovh-testacc#2151.0 ✔
*

  • checks ✔

@amstuta amstuta merged commit 9d2a5c7 into master Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Fail to retrieve S3 secret
3 participants