Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solve issue 439 #458

Conversation

yomovh
Copy link
Contributor

@yomovh yomovh commented Aug 25, 2023

Description

  • Update dedicated_ipfo attribute to TypeSet
  • Update http frontend test to add failover IP attributes

Fixes #439

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A: make testacc TESTARGS="-run TestAccIpLoadbalancingHttpFrontend_basic"

Checklist:

  • [X ] My code follows the style guidelines of this project
  • [X ] I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • [X ] I have made corresponding changes to the documentation
  • [ X] My changes generate no new warnings or issues
  • [ X] I have added acceptance tests that prove my fix is effective or that my feature works
  • [ X] New and existing acceptance tests pass locally with my changes
  • [X ] I ran succesfully go mod vendor if I added or modify go.mod file

- Update dedicated_ipfo attribute to TypeSet
@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 27, 2023

CDS Report terraform-provider-ovh-testacc#1939.0 ✘
*

  • checks ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Aug 27, 2023

CDS Report terraform-provider-ovh-testacc#1940.0 ✘
*

  • checks ✘

@scraly scraly added the 0.34.0 label Aug 28, 2023
@scraly scraly merged commit 4f9c217 into master Aug 28, 2023
@scraly
Copy link
Collaborator

scraly commented Aug 28, 2023

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] API returns data in a different order and generates meaningless change
3 participants