-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for IAM policies (beta) #424
Conversation
* `name` - Name of the policy. | ||
* `description` - Group description. | ||
* `identities` - List of identities affected by the policy. | ||
* `resources` - List of resources the policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* `resources` - List of resources the policy. | |
* `resources` - List of resources affected by the policy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
several remarks, questions and suggestions :)
## Argument Reference | ||
|
||
## Attributes Reference | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here an example of how an ID of a data source that list registry capabilities is setted:
https://github.com/ovh/terraform-provider-ovh/blob/master/ovh/data_cloud_project_capabilities_containerregistry.go
just a hash generated with the string in input
and here you can find what to say for the ID in the doc:
https://registry.terraform.io/providers/ovh/ovh/latest/docs/data-sources/cloud_project_capabilities_containerregistry
For this kind of ID is not easy and suepr useful but I think we need to documente very fields :)
b7c5526
to
ac827bb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
I found some flaws that we would have to address before merging this one.
Let's talk about it if you think I'm in the wrong :)
Romain
Signed-off-by: Nicolas FOURNIER <nicolas.fournier@ovhcloud.com>
957b487
to
8e678cb
Compare
Signed-off-by: Nicolas FOURNIER <nicolas.fournier@ovhcloud.com>
At the time of this commit, as a prerequisite to using the IAM, the accounts must be part of the feature beta. This adds a banner on affected resources and data sources.
Description
This adds support for IAM policies, which are currently in private beta.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Since the IAM is currently in beta, test must be performed on an account which is participating in the beta.
make testacc TESTARGS="-run TestAccDataSourceXxxxYyyyZzzzz_basic"
Test Configuration:
terraform version
: Terraform v1.4.6Checklist:
go mod vendor
if I added or modifygo.mod
file