Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

desired_nodes to 0 was not taken into account into ovh_cloud_project_kube_nodepool resource #389

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

SkYNewZ
Copy link
Contributor

@SkYNewZ SkYNewZ commented Feb 23, 2023

Description

desired_nodes to 0 was not taken into account into ovh_cloud_project_kube_nodepool resource.
This is now fixed.

Fixes #370

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test: make testacc TESTARGS="-run TestAccCloudProjectKubeNodePool"

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings or issues
  • I have added acceptance tests that prove my fix is effective or that my feature works
  • New and existing acceptance tests pass locally with my changes
  • I ran succesfully go mod vendor if I added or modify go.mod file

@scraly
Copy link
Collaborator

scraly commented Mar 16, 2023

  • Created a node pool with one desired node
NAME              FLAVOR   AUTOSCALED   MONTHLYBILLED   ANTIAFFINITY   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   MIN   MAX   AGE
my-desired-pool   b2-7     false        false           false          1         1         1            0           0     3     3m26s
  • Changed to 0
NAME              FLAVOR   AUTOSCALED   MONTHLYBILLED   ANTIAFFINITY   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   MIN   MAX   AGE
my-desired-pool   b2-7     false        false           false          0         1         1            0           0     3     4m56s
  • Changed to 2
$ kubectl get np
NAME              FLAVOR   AUTOSCALED   MONTHLYBILLED   ANTIAFFINITY   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   MIN   MAX   AGE
my-desired-pool   b2-7     false        false           false          2         2         2            1           0     3     9m56s
  • Change again to 0
NAME              FLAVOR   AUTOSCALED   MONTHLYBILLED   ANTIAFFINITY   DESIRED   CURRENT   UP-TO-DATE   AVAILABLE   MIN   MAX   AGE
my-desired-pool   b2-7     false        false           false          0         0         0            0           0     3     13m

Perfect :)

@scraly scraly added the 0.29.0 label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scale kubernetes pool to 0 not work using Terraform
2 participants