Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iploadbalancing): Add iploadbalancing importers #140

Merged
merged 1 commit into from
Apr 28, 2020

Conversation

Kaswob
Copy link

@Kaswob Kaswob commented Apr 20, 2020

Add importers for all iploadbalancing resources
Refactor read function of iplb Tcp & Http farm
Add tests for iplb importers
Fix typo in 'oco' probe type
Small lint fixes for iplb

Add importers for all iploadbalancing resources
Refactor read function of iplb Tcp & Http farm
Add tests for iplb importers
Fix typo in 'oco' probe type
Small lint fixes for iplb
@ghost ghost added the size/XL label Apr 20, 2020
@yanndegat
Copy link
Collaborator

Hi @Kaswob

thanks a lot for this great job

LGTM

as it's a big PR asking a for a second reviewer
@pgaxatte ?

@yanndegat yanndegat requested a review from pgaxatte April 21, 2020 07:04
Copy link
Contributor

@pgaxatte pgaxatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome contribution, thanks!
lgtm

@yanndegat yanndegat merged commit 4024cb9 into ovh:master Apr 28, 2020
@yanndegat
Copy link
Collaborator

merging, acctest green on TC

@yanndegat
Copy link
Collaborator

thanks again kamil for this great work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants