Fix issues open on github #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -128,6 +128,8 @@ public function __construct( | |||
|
|
|||
| if (!isset($http_client)) { | |||
| $http_client = new GClient(); | |||
| $http_client->setDefaultOption('timeout', 30); | |||
There was a problem hiding this comment.
Some API calls may take up to 5min. While this is an edge case, it may impact some of the developers needing the most an API. As the connect_timeout is a separate parameter, I'd increase it.
There was a problem hiding this comment.
That's the default configuration. But you can put your own Gclient with custom timeout if you want. I add it into the documentation
Signed-off-by: Vincent Casse <vincent.casse@corp.ovh.com>
|
LGTM |
yadutaf
added a commit
that referenced
this pull request
Dec 16, 2015
Fix issues open on github Signed-off-by: Jean-Tiare Le Bigot <jean-tiare.le-bigot@corp.ovh.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some open issues on github