Skip to content

fix(pci-workflow): make region selector required #20788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aTurmo wants to merge 2 commits into
base: epic/workflow-fixes
Choose a base branch
from
Open

fix(pci-workflow): make region selector required #20788

aTurmo wants to merge 2 commits into from
+28 −14

Conversation

@aTurmo
Copy link
Contributor

@aTurmo aTurmo commented Dec 3, 2025

No description provided.

@aTurmo aTurmo requested a review from a team as a code owner December 3, 2025 10:23
@github-actions github-actions bot added universe-public-cloud bug Something isn't working labels Dec 3, 2025
Base automatically changed from release/pci-workflow-w49 to master December 3, 2025 13:01
@github-actions github-actions bot added the has conflicts Has conflicts to resolve before merging label Dec 3, 2025
@aTurmo aTurmo force-pushed the fix/pci-workflow-w49_required_distant_region branch from ae30489 to cd6e380 Compare December 4, 2025 09:28
@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Dec 4, 2025
@aTurmo aTurmo force-pushed the fix/pci-workflow-w49_required_distant_region branch from cd6e380 to d04e587 Compare December 4, 2025 09:30
@aTurmo
fix(pci-workflow): make region selector required
d15f893 
ref: #TAPC-5416

Signed-off-by: Adrien Turmo <adrien.turmo.ext@ovhcloud.com>
@aTurmo aTurmo force-pushed the fix/pci-workflow-w49_required_distant_region branch from d04e587 to d15f893 Compare December 4, 2025 09:42
@aTurmo aTurmo changed the base branch from master to epic/workflow-fixes December 4, 2025 10:04
fredericvilcot
fredericvilcot approved these changes Dec 4, 2025
View reviewed changes
Copy link
Contributor

@fredericvilcot fredericvilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

packages/manager/apps/pci-workflow/src/pages/new/components/DistantBackup.component.tsx Outdated
distantRegion: string;
onChange: (distantRegion: string | null) => void;
isDistantBackup: boolean;
onChangeIsDistantBackup: (newValue: boolean) => void;
Copy link
Contributor

@fredericvilcot fredericvilcot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
onChangeIsDistantBackup: (newValue: boolean) => void;
onIsDistantBackupChange: (newValue: boolean) => void;

@aTurmo
fix(pci-workflow): rename distant backup component props
bc448ed 
ref: #TAPC-5416

Signed-off-by: Adrien Turmo <adrien.turmo.ext@ovhcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ppprevost ppprevost ppprevost approved these changes

@Tsiorifamonjena Tsiorifamonjena Tsiorifamonjena approved these changes

@lolottetheclash lolottetheclash lolottetheclash approved these changes

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@Taelar Taelar Awaiting requested review from Taelar Taelar is a code owner automatically assigned from ovh/dev-manager-pci-all

@ZyaCon ZyaCon Awaiting requested review from ZyaCon ZyaCon is a code owner automatically assigned from ovh/dev-manager-pci-all

Assignees

No one assigned

Labels

bug Something isn't working universe-public-cloud

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@aTurmo @ppprevost @Tsiorifamonjena @lolottetheclash @fredericvilcot