feat(web.zone): add dns server section for zone standalone #16859
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ref: #MANAGER-13869 Signed-off-by: Guillaume Hyenne <guillaume.hyenne@ovhcloud.com>
tristanwagner
approved these changes
Apr 30, 2025
tibs245
reviewed
May 2, 2025
Comment on lines
+65
to
+68
| const promise = | ||
| this.currentSection === 'domain' | ||
| ? [this.getDomain(), this.hasAnycast(), this.getDns()] | ||
| : [this.getDns()]; |
There was a problem hiding this comment.
Suggested change
| const promise = | |
| this.currentSection === 'domain' | |
| ? [this.getDomain(), this.hasAnycast(), this.getDns()] | |
| : [this.getDns()]; | |
| const promises = | |
| this.currentSection === 'domain' | |
| ? [this.getDomain(), this.hasAnycast(), this.getDns()] | |
| : [this.getDns()]; |
tibs245
reviewed
May 2, 2025
| return this.$q | ||
| .all([this.getDomain(), this.hasAnycast(), this.getDns()]) | ||
| .all(promise) |
There was a problem hiding this comment.
Suggested change
| .all(promise) | |
| .all(promises) |
tibs245
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I reuse the existing code for zone attached to domain
Ticket Reference: #MANAGER-13869
Additional Information