Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: service logs workflow v2 #6684

Merged
merged 24 commits into from
Nov 29, 2023
Merged

feat: service logs workflow v2 #6684

merged 24 commits into from
Nov 29, 2023

Conversation

yesnault
Copy link
Member

No description provided.

@ovh ovh deleted a comment from ovh-cds Nov 14, 2023
@ovh ovh deleted a comment from ovh-cds Nov 14, 2023
@ovh ovh deleted a comment from ovh-cds Nov 14, 2023
@ovh ovh deleted a comment from ovh-cds Nov 14, 2023
sguiheux
sguiheux requested changes Nov 14, 2023
View reviewed changes
engine/api/v2_hatchery.go Outdated Show resolved Hide resolved
engine/worker/internal/types.go Outdated Show resolved Hide resolved
engine/worker/internal/types.go Outdated Show resolved Hide resolved
sdk/v2_workflow.go Outdated Show resolved Hide resolved
sdk/v2_workflow.go Outdated Show resolved Hide resolved
sdk/v2_workflow.go Outdated Show resolved Hide resolved
ui/src/app/views/projectv2/run/run-job-logs.component.ts Outdated Show resolved Hide resolved
ui/src/app/views/projectv2/run/run-job-logs.component.ts Outdated Show resolved Hide resolved
fsamin
fsamin requested changes Nov 14, 2023
View reviewed changes
Copy link
Member

@fsamin fsamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an integration test ?

engine/api/services/http.go Outdated Show resolved Hide resolved
engine/api/v2_hatchery.go Outdated Show resolved Hide resolved
engine/api/v2_workflow_run_job_routines.go Outdated Show resolved Hide resolved
engine/worker/internal/types.go Outdated Show resolved Hide resolved
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 14, 2023

CDS Report build-all-cds#19413.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✘
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 14, 2023

CDS Report build-all-cds#19416.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@yesnault
Copy link
Member Author

Can you add an integration test ?

yes, incoming

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 21, 2023

CDS Report build-all-cds#19471.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 21, 2023

CDS Report build-all-cds#19474.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 21, 2023

CDS Report build-all-cds#19476.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✘
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 21, 2023

CDS Report build-all-cds#19477.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 27, 2023

CDS Report build-cds#19555.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 27, 2023

CDS Report integration-cds#19555.0 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 28, 2023

CDS Report build-cds#19560.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 28, 2023

CDS Report integration-cds#19560.0 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@yesnault
Copy link
Member Author

Can you add an integration test ?

done

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report build-cds#19573.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report integration-cds#19573.0 ✘

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✘

yesnault and others added 15 commits November 29, 2023 10:56
@yesnault
fix: logs
4ca2ed4 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: ut
a0429be 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
test: ut
7f919cf 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
test: ut
93d952b 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault @fsamin
Update engine/api/v2_workflow_run_job_routines.go
ebcaaab 
Co-authored-by: François Samin <francois.samin@corp.ovh.com>
@yesnault
fix: cr
37e61d2 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: ut
661a8c6 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: ut
8add28b 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: venom 1.2
a028412 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: it
95f3389 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: it
9be3384 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: it
3522f16 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: cr
3a8cc9b 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: it
9833d35 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@yesnault
fix: it
7904e8d 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report build-cds#19582.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report integration-cds#19582.0 ✘

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✘

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report integration-cds#19582.1 ✘

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✘

@yesnault
fix: it
f43bbf3 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report build-cds#19586.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report build-cds#19586.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report integration-cds#19586.0 ■

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ■
    • Standalone Tests v2 ■

1 similar comment
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report integration-cds#19586.0 ■

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ■
    • Standalone Tests v2 ■

@yesnault
fix: increase retry
0eff562 
Signed-off-by: Yvonnick Esnault <yvonnick.esnault@corp.ovh.com>
@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report build-cds#19587.0 ✔

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

@ovh-cds
Copy link
Collaborator

ovh-cds commented Nov 29, 2023

CDS Report integration-cds#19587.0 ✔

  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✔
    • Standalone Tests v1 ✔
    • Standalone Tests v2 ✔

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@yesnault yesnault merged commit 4496b6a into master Nov 29, 2023
5 checks passed
@yesnault yesnault deleted the ye-1699030873 branch December 7, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@sguiheux sguiheux sguiheux approved these changes

@fsamin fsamin fsamin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yesnault @ovh-cds @fsamin @sguiheux @richardlt