Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hook,api): retrieve hook initiator before running workflow #6626

Merged
merged 3 commits into from
Oct 5, 2023
Merged

feat(hook,api): retrieve hook initiator before running workflow #6626

merged 3 commits into from
Oct 5, 2023

Conversation

sguiheux
Copy link
Collaborator

@sguiheux sguiheux commented Oct 2, 2023

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 2, 2023

CDS Report build-all-cds#19179.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✘
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔

fsamin
fsamin approved these changes Oct 5, 2023
View reviewed changes
engine/api/v2_hooks.go
}

api.GoRoutines.Exec(context.Background(), "operation-pooling-"+ope.UUID, func(ctx context.Context) {
ope, err := operation.Poll(ctx, api.mustDB(), ope.UUID)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any timeout ?

@ovh-cds
Copy link
Collaborator

ovh-cds commented Oct 5, 2023

CDS Report build-all-cds#19195.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

60.8% 60.8% Coverage
6.1% 6.1% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sguiheux sguiheux merged commit f1a8c41 into master Oct 5, 2023
3 of 4 checks passed
@sguiheux sguiheux deleted the hookRetrieveInitiator branch October 5, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlt richardlt richardlt approved these changes

@fsamin fsamin fsamin approved these changes

@yesnault yesnault Awaiting requested review from yesnault yesnault is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sguiheux @ovh-cds @fsamin @richardlt