Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui,api): ascode action form & analysis #6513

Merged
merged 16 commits into from
Mar 22, 2023
Merged

feat(ui,api): ascode action form & analysis #6513

merged 16 commits into from
Mar 22, 2023

Conversation

sguiheux
Copy link
Collaborator

  1. Description
  2. Related issues
  3. About tests
  4. Mentions

@ovh/cds

@ovh-cds
Copy link
Collaborator

ovh-cds commented Mar 21, 2023

CDS Report build-all-cds#18662.0 ✘

  • Build
    • Build and Package All ✔
    • Build Debpacker ✔
    • Build OS-Ansible-Inventory ✔
    • Build SMTPMock ✔
    • Lint UI Translate ✔
    • Test CLI ✔
    • Test Engine ✔
    • Test SDK ✔
    • Test UI ✔
  • Package
    • Docker ✔
  • Integration
    • Docker Compose Tests ✔
    • Standalone Tests ✘

@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 11 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sguiheux sguiheux marked this pull request as ready for review March 21, 2023 12:53
fsamin
fsamin reviewed Mar 22, 2023
View reviewed changes
tests/fixtures/ITCLIPRJVCS/my-action.yml
- run: echo Welcome in nthis new action
- id: hello
run: echo Hello ${{ inputs.name }}
- run: echo "name=${{ inputs.name }}" >> $CDS_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any tests with use and with ?

sdk/v2_action.go
return a.Name
}

func (a V2Action) Lint() []error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need unit test on Lint() ?

@sguiheux sguiheux merged commit 1c52b9d into master Mar 22, 2023
@sguiheux sguiheux deleted the actionAsCodeForm2 branch March 22, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsamin fsamin fsamin left review comments

@richardlt richardlt richardlt approved these changes

@yesnault yesnault yesnault approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sguiheux @ovh-cds @yesnault @fsamin @richardlt