Skip to content

Create Dockerfile - #1805

Closed
TheDruidsKeeper wants to merge 1 commit into
overviewer:masterfrom
TheDruidsKeeper:patch-1
Closed

TheDruidsKeeper wants to merge 1 commit into
overviewer:masterfrom
TheDruidsKeeper:patch-1

Conversation

@TheDruidsKeeper

Copy link
Copy Markdown

This dockerfile gives an easy way for users to build the source and run locally with no dependencies beyond docker. Volume mounts must be used to provide files needed for runtime. Ex (using Windows paths):

docker build -t minecraft-overviewer .
docker run --rm -v F:/minecraft/client.jar:/root/.minecraft/versions/1.16/1.16.jar -v F:/minecraft/HelloWorld:/var/minecraft/input -v F:/minecraft/mcmap:/var/minecraft/output minecraft-overviewer /var/minecraft/input /var/minecraft/output

Example volume mounts explained:

  1. the client.jar required for textures
  2. the world to render, matches the first parameter passed to the image entrypoint
  3. the where the map is saved to, matches the second parameter passed to the image entrypoint

This dockerfile gives an easy way for users to build the source and run locally with no dependencies beyond docker. Volume mounts must be used to provide files needed for runtime. Ex (using Windows paths):
```
docker build -t minecraft-overviewer .
docker run --rm -v F:/minecraft/client.jar:/root/.minecraft/versions/1.16/1.16.jar -v F:/minecraft/HelloWorld:/var/minecraft/input -v F:/minecraft/mcmap:/var/minecraft/output minecraft-overviewer /var/minecraft/input /var/minecraft/output
```

Example volume mounts explained:
1. the client.jar [required for textures](http://docs.overviewer.org/en/latest/running/#installing-the-textures)
2. the world to render, matches the first parameter passed to the image entrypoint
3. the where the map is saved to, matches the second parameter passed to the image entrypoint
@CounterPillow

Copy link
Copy Markdown
Member

I don't want to maintain a dockerfile, so I will not be merging this.

@TheDruidsKeeper

Copy link
Copy Markdown
Author

@CounterPillow I'd like to ask you to reconsider. I'm happy to continue maintaining it myself, and even work on creating documentation to show examples of how to use it. I'd even be interested in setting up a CI pipeline to automatically build & publish new images. If, for some reason, I don't support it well enough you could always remove it at that point, but this is a great project that I'd be more than happy to be a part of.

@CounterPillow

Copy link
Copy Markdown
Member

You can happily maintain your Dockerfile outside of this repository.

@eminence

eminence commented Jul 7, 2020

Copy link
Copy Markdown
Member

If you wanted to maintain the dockerfile in the wiki on github, that sounds like it could be good too

@TheDruidsKeeper

TheDruidsKeeper commented Jul 8, 2020

Copy link
Copy Markdown
Author

Added to my own repo as requested (linking here in case other people come across this thread).

@TheDruidsKeeper
TheDruidsKeeper deleted the patch-1 branch July 8, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants