Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

加快拼音转文字的速度 #31

Merged
merged 2 commits into from
Jan 18, 2016

Conversation

xjchengo
Copy link
Contributor

No description provided.

@overtrue
Copy link
Owner

@xjchengo
Copy link
Contributor Author

我第一个 commit message 写错了,应该是“加快文字转拼音的速度”。
支持的 PHP 版本如果在 composer.json 中体现一下可能会清晰一点。

$pinyin = strtr($this->prepare($string), self::$dictionary);
$preparedString = $this->prepare($string);
$count = mb_strlen($preparedString, static::$internalCharset);
$dictionary = [];
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请兼容 PHP 5.3

@xjchengo
Copy link
Contributor Author

已兼容 PHP 5.3。看你添加的测试是要做一下benchmark吗?

overtrue added a commit that referenced this pull request Jan 18, 2016
@overtrue overtrue merged commit 17cd2c7 into overtrue:master Jan 18, 2016
@overtrue
Copy link
Owner

@xjchengo 谢谢!

overtrue added a commit that referenced this pull request Nov 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants