Fix airpods recording #783
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # Telegram-Mac/Info.plist # TelegramShare/Info.plist
# Conflicts: # Telegram-Mac/Info.plist # TelegramShare/Info.plist
|
|
dm3ch
force-pushed
the
fix-airpods-recording
branch
from
2765252 to
854ec94
Compare
Author
|
@overtake Sorry for the mention, but maybe you can take a look at this PR. The problem with airpods is very annoying for me and some other users. |
Owner
|
i didn't notice this PR. Sorry. anyway. fixed. thanks. i fixed in the same way |
|
@overtake How to know when this will be released on the app store? It still does not work for me with the app store build. |
Owner
i will send to review today. i bet on weekends or next week. you also can switch to stable version macos.telegram.org. 9.3 coming today. |
nimayusfi
approved these changes
Sep 6, 2023
|
Hi @overtake Do you happen to have any updates on this PR? The bug still occurs. |
overtake
force-pushed
the
master
branch
3 times, most recently
from
9aa8690 to
579cebb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a very naive attempt to fix a bug with AirPods (24kHZ sample rate) recorded voice messages.
I just added "resampling" code similar to what it's already there for 16kHZ. Now in my self-built version of Telegram client, I haven't got a speedup of recording and voice pitch.
Actually, it would be better to write universal re-sampling code, but I'm pretty bad in audio and in swift to do it myself.
During the research I also found that in iOS client (https://github.com/TelegramMessenger/Telegram-iOS/blob/702f2547830ca406ce41081ea4170f24533f9a01/submodules/TelegramUI/Sources/ManagedAudioRecorder.swift ) there's pretty similar part of code for audio recording but it doesn't have transcoding and it works great with AirPods, actually I don't know why, but it's too much differences to easily port it to this project for me.
#112 #590 #692