Skip to content

Update port #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update port #242

wants to merge 1 commit into from

Conversation

dylanratcliffe
Copy link
Member

No description provided.

Copy link

Overmind

Open in Overmind ↗


✨ami_update

🔥 Risks

Risk of Unhealthy ECS Tasks Due to Port Mismatch and Security Configuration Issues. ‼️High Open Risk ↗
The proposed change to update the ECS task definition's health check to use port 8080 introduces a risk of the application being marked as unhealthy if it is not configured to listen on this port. The current container port mapping still shows port 1234, indicating a potential configuration mismatch. Additionally, the security group does not explicitly allow traffic on port 8080, which could block necessary health check traffic. The ELB target group is also configured for port 1234, which may prevent proper routing if the application is expected to listen on port 8080.

Risk of Unhealthy ECS Tasks Due to Port Mismatch and Security Configuration Issues. ‼️High Open Risk ↗
The proposed change to update the ECS task definition's health check to use port 8080 introduces a risk of the application being marked as unhealthy if it is not configured to listen on this port. The current container port mapping still shows port 1234, indicating a potential configuration mismatch. Additionally, the security group does not explicitly allow traffic on port 8080, which could block necessary health check traffic. The ELB target group is also configured for port 1234, which may prevent proper routing if the application is expected to listen on port 8080.


🟣 Expected Changes

+/- ecs-task-definition › facial-recognition-terraform-example
- arn: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:7
+ arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- arn_without_revision: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example
+ arn_without_revision: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- container_definitions: [{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20240827194315707700000013.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:1234"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234,"hostPort":1234,"protocol":"tcp"}],"systemControls":[],"volumesFrom":[]}]
+ container_definitions: [{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20240827194315707700000013.cnx7xf6hwmba.eu-west-2.rds.amazonaws.com"}],"essential":true,"healthCheck":{"command":["CMD-SHELL","wget -q --spider localhost:8080"],"interval":30,"retries":3,"timeout":5},"image":"harshmanvar/face-detection-tensorjs:slim-amd","memory":2048,"mountPoints":[],"name":"facial-recognition","portMappings":[{"appProtocol":"http","containerPort":1234}],"volumesFrom":[]}]
# → 🔁 This attribute has changed 2 times in the last 30 days.
#      The previous values were [(known after apply) [{"cpu":1024,"environment":[{"name":"DATABASE_URL","value":"tf-20240827194315707700000013.cnx7xf6hwm].
- enable_fault_injection: false
+ enable_fault_injection: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- execution_role_arn: 
+ execution_role_arn: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
- id: facial-recognition-terraform-example
+ id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ipc_mode: 
+ ipc_mode: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
- pid_mode: 
+ pid_mode: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
- revision: 7
+ revision: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
+ tags: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
+ tags_all: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- task_role_arn: 
+ task_role_arn: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
+/- ec2-instance › i-026d85b6a17c8cb6a
- ami: ami-0e3d5b891b5414b2d
+ ami: ami-0541786b7b80f7333
# → 🔁 This attribute has changed 2 times in the last 30 days.
#      The previous values were [ami-0e3d5b891b5414b2d ami-0fd1f73e93aea486e].
- arn: arn:aws:ec2:eu-west-2:540044833068:instance/i-026d85b6a17c8cb6a
+ arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- availability_zone: eu-west-2b
+ availability_zone: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- capacity_reservation_specification: [map[capacity_reservation_preference:open capacity_reservation_target:[]]]
+ capacity_reservation_specification: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- cpu_core_count: 1
+ cpu_core_count: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- cpu_options: [map[amd_sev_snp: core_count:1 threads_per_core:2]]
+ cpu_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- cpu_threads_per_core: 2
+ cpu_threads_per_core: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- credit_specification: [map[cpu_credits:unlimited]]
+ credit_specification: []
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [[]].
- disable_api_stop: false
+ disable_api_stop: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- disable_api_termination: false
+ disable_api_termination: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ebs_block_device: []
+ ebs_block_device: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ebs_optimized: false
+ ebs_optimized: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- enable_primary_ipv6: <nil>
+ enable_primary_ipv6: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- enclave_options: [map[enabled:false]]
+ enclave_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ephemeral_block_device: []
+ ephemeral_block_device: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- hibernation: false
+ hibernation: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
- host_id: 
+ host_id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- host_resource_group_arn: <nil>
+ host_resource_group_arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- iam_instance_profile: 
+ iam_instance_profile: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- id: i-026d85b6a17c8cb6a
+ id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_initiated_shutdown_behavior: stop
+ instance_initiated_shutdown_behavior: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_lifecycle: 
+ instance_lifecycle: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_market_options: []
+ instance_market_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_state: running
+ instance_state: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ipv6_address_count: 0
+ ipv6_address_count: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ipv6_addresses: []
+ ipv6_addresses: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- maintenance_options: [map[auto_recovery:default]]
+ maintenance_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- metadata_options: [map[http_endpoint:enabled http_protocol_ipv6:disabled http_put_response_hop_limit:1 http_tokens:optional instance_metadata_tags:disabled]]
+ metadata_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- monitoring: false
+ monitoring: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- network_interface: []
+ network_interface: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- outpost_arn: 
+ outpost_arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- password_data: 
+ password_data: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- placement_group: 
+ placement_group: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- placement_partition_number: 0
+ placement_partition_number: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- primary_network_interface_id: eni-0c1f560e62289ba70
+ primary_network_interface_id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- private_dns: ip-10-0-10-97.eu-west-2.compute.internal
+ private_dns: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- private_dns_name_options: [map[enable_resource_name_dns_a_record:false enable_resource_name_dns_aaaa_record:false hostname_type:ip-name]]
+ private_dns_name_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- private_ip: 10.0.10.97
+ private_ip: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- public_dns: ec2-18-134-16-24.eu-west-2.compute.amazonaws.com
+ public_dns: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- public_ip: 18.134.16.24
+ public_ip: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- root_block_device: [map[delete_on_termination:true device_name:/dev/xvda encrypted:false iops:0 kms_key_id: tags:map[] tags_all:map[] throughput:0 volume_id:vol-0d8f6d19ad464a713 volume_size:8 volume_type:standard]]
+ root_block_device: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- secondary_private_ips: []
+ secondary_private_ips: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- security_groups: []
+ security_groups: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- spot_instance_request_id: 
+ spot_instance_request_id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- tenancy: default
+ tenancy: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- user_data: <nil>
+ user_data: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- user_data_base64: <nil>
+ user_data_base64: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
+/- ec2-instance › i-0dbe8ac8052b46048
- ami: ami-0e3d5b891b5414b2d
+ ami: ami-0541786b7b80f7333
# → 🔁 This attribute has changed 2 times in the last 30 days.
#      The previous values were [ami-0e3d5b891b5414b2d ami-0fd1f73e93aea486e].
- arn: arn:aws:ec2:eu-west-2:540044833068:instance/i-0dbe8ac8052b46048
+ arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- availability_zone: eu-west-2a
+ availability_zone: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- capacity_reservation_specification: [map[capacity_reservation_preference:open capacity_reservation_target:[]]]
+ capacity_reservation_specification: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- cpu_core_count: 1
+ cpu_core_count: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- cpu_options: [map[amd_sev_snp: core_count:1 threads_per_core:2]]
+ cpu_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- cpu_threads_per_core: 2
+ cpu_threads_per_core: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- credit_specification: [map[cpu_credits:unlimited]]
+ credit_specification: []
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [[]].
- disable_api_stop: false
+ disable_api_stop: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- disable_api_termination: false
+ disable_api_termination: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ebs_block_device: []
+ ebs_block_device: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ebs_optimized: false
+ ebs_optimized: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- enable_primary_ipv6: <nil>
+ enable_primary_ipv6: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- enclave_options: [map[enabled:false]]
+ enclave_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ephemeral_block_device: []
+ ephemeral_block_device: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- hibernation: false
+ hibernation: <nil>
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [<nil>].
- host_id: 
+ host_id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- host_resource_group_arn: <nil>
+ host_resource_group_arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- iam_instance_profile: 
+ iam_instance_profile: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- id: i-0dbe8ac8052b46048
+ id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_initiated_shutdown_behavior: stop
+ instance_initiated_shutdown_behavior: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_lifecycle: 
+ instance_lifecycle: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_market_options: []
+ instance_market_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- instance_state: running
+ instance_state: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ipv6_address_count: 0
+ ipv6_address_count: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- ipv6_addresses: []
+ ipv6_addresses: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- maintenance_options: [map[auto_recovery:default]]
+ maintenance_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- metadata_options: [map[http_endpoint:enabled http_protocol_ipv6:disabled http_put_response_hop_limit:1 http_tokens:optional instance_metadata_tags:disabled]]
+ metadata_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- monitoring: false
+ monitoring: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- network_interface: []
+ network_interface: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- outpost_arn: 
+ outpost_arn: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- password_data: 
+ password_data: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- placement_group: 
+ placement_group: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- placement_partition_number: 0
+ placement_partition_number: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- primary_network_interface_id: eni-0f05a9f94c2428635
+ primary_network_interface_id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- private_dns: ip-10-0-9-50.eu-west-2.compute.internal
+ private_dns: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- private_dns_name_options: [map[enable_resource_name_dns_a_record:false enable_resource_name_dns_aaaa_record:false hostname_type:ip-name]]
+ private_dns_name_options: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- private_ip: 10.0.9.50
+ private_ip: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- public_dns: ec2-13-40-69-90.eu-west-2.compute.amazonaws.com
+ public_dns: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- public_ip: 13.40.69.90
+ public_ip: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- root_block_device: [map[delete_on_termination:true device_name:/dev/xvda encrypted:false iops:0 kms_key_id: tags:map[] tags_all:map[] throughput:0 volume_id:vol-078903baa7c5d1cc8 volume_size:8 volume_type:standard]]
+ root_block_device: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- secondary_private_ips: []
+ secondary_private_ips: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- security_groups: []
+ security_groups: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- spot_instance_request_id: 
+ spot_instance_request_id: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- tenancy: default
+ tenancy: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- user_data: <nil>
+ user_data: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
- user_data_base64: <nil>
+ user_data_base64: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].
~ ec2-launch-template › lt-0731f767e6be2ab94
- image_id: ami-0e3d5b891b5414b2d
+ image_id: ami-0541786b7b80f7333
# → 🔁 This attribute has changed 2 times in the last 30 days.
#      The previous values were [ami-0e3d5b891b5414b2d ami-0fd1f73e93aea486e].
- latest_version: 12
+ latest_version: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].

🟠 Unmapped Changes

~ aws_ecs_service › module.scenarios[0].aws_ecs_service.face
- task_definition: arn:aws:ecs:eu-west-2:540044833068:task-definition/facial-recognition-terraform-example:7
+ task_definition: (known after apply)
# → 🔁 This attribute has changed 1 times in the last 30 days.
#      The previous values were [(known after apply)].

💥 Blast Radius

Items 28

Edges 39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant