fix: upgrade MySQL from 5.7 to 8.1 first and then to 8.4 #1102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regisb
reviewed
Jul 29, 2024
This is required when upgrading from Tutor v15 to v18 directly MySQL does not allow direct upgrades from v5.7 to v8.4
Danyal-Faheem
force-pushed
the
danyalfaheem/upgrade-mysql-5.7-to-8.4
branch
from
1be1091
to
c31f2e9
Compare
DawoudSheraz
reviewed
Aug 8, 2024
DawoudSheraz
reviewed
Aug 8, 2024
|
@regisb FYI |
regisb
reviewed
Aug 13, 2024
DawoudSheraz
approved these changes
Aug 19, 2024
|
Hello @regisb, can u please have a look at this PR. |
regisb
requested changes
Sep 24, 2024
regisb
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user attempts to directly upgrade their tutor instance from tutor v15 or earlier to tutor v18 or later, i.e upgrade from MySQL v5.7 or earlier to MySQL v8.4 or later, MySQL will crash with the container getting stuck in a boot loop. This is because upgrading directly from MySQL v5.7 -> v8.4 is not allowed. We therefore first jump to v8.1, build the data dictionary and then go to v8.4.
Note that this issue does not occur if one attempts to upgrade to tutor v16 or v17 first and then to tutor v18 because that upgrade path is acceptable for MySQL.