Fix Accessibility Issues Reported During Accessibility Review #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 6, 2025
The focused "View Course" button is hard to read because of the outline going through the text. Does this fall in the scope of this PR? |
|
@mlabeeb03 Thanks for pointing that out! Just to help me reproduce the issue accurately, could you please let me know which browser (if possible) you're using to test this? |
|
@arbirali I'm using firefox developer edition. |
|
Hi @mlabeeb03! Any reason why this PR wasn't merged, since you approved it? |
|
@regisb I think one of the indigo maintainers will merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request resolves several accessibility issues in the Tutor Indigo theme that were identified during a recent accessibility review. These updates aim to improve usability for all users, especially those relying on assistive technologies. The changes also help ensure compliance with recognized accessibility standards, such as the Web Content Accessibility Guidelines (WCAG) 2.1.
For further details, please refer to the related issue: overhangio/tutor-indigo#146.
Accessibility Fixes Implemented
Search Bar Focus Correct Order
The search bar on the progress page was receiving keyboard focus after the search button, which disrupted the expected tab order. This has been corrected so that the search bar receives focus before the button.
Makes the Focus Visible on the Navigation Bar
On the instructor dashboard, the focus state for navigation items like "Course Info" was not visible. This has been fixed by adding clear outlines to indicate keyboard focus.
Focus on the Theme Toggle Button
The theme toggle button lacked a visible focus indicator for keyboard users. This has been addressed by ensuring a clear focus style is applied.
Remove Focus from the "Already Enrolled" Button
Previously, the "Already Enrolled" and "View Course" buttons were highlighted simultaneously, creating confusion. This issue has been fixed so that focus is only applied to the appropriate interactive element.
Accessibility Audit Report
For the full audit and issue breakdown, please refer to the following report:
Accessibility Audit - Taiga US/111