feat: upgrade to olive #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2022
regisb
reviewed
Nov 14, 2022
regisb
reviewed
Nov 14, 2022
regisb
reviewed
Nov 14, 2022
regisb
reviewed
Nov 14, 2022
regisb
reviewed
Dec 9, 2022
ghassanmas
force-pushed
the
olive
branch
2 times, most recently
from
401b5d1 to
5a57cc3
Compare
regisb
approved these changes
Dec 12, 2022
Contributor
regisb
left a comment
regisb
left a comment
There was a problem hiding this comment.
Looking good. Can you please just squash your commits?
Member
Author
|
Its just two unrelated commits, one for upgrade and other docs. Do you prefer them to be combined into one |
Contributor
|
Yes, please combine them into one. The reason is that if we merge both commits at once the v15.0.0 tag will be applied to the last one, which is the one about the maintainer. |
- Now this plugin does rely on Ruby 3 - make it clear who maintain is, Close #12
regisb
approved these changes
Dec 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still work in progress.
This upgrade to ruby to 3.0.4 based on this openedx-unsupported/cs_comments_service/pull/392 and openedx-unsupported/cs_comments_service/pull/395