Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Python 3.11 upgrade #41

Merged
merged 4 commits into from
May 14, 2024
Merged

Enhancement: Python 3.11 upgrade #41

merged 4 commits into from
May 14, 2024

Conversation

Faraz32123
Copy link
Collaborator

@Faraz32123 Faraz32123 commented May 8, 2024 •
edited
Loading

close #34
NOTES:

  • Credentials codebase is not compatible with python3.12 yet.
  • CI: temporarily skipping building on arm64. As the upstream credentials repo seems to be breaking on arm64 and they are skipping arm64 builds as well due to the didkit package dependency not available on arm64 yet.

@Faraz32123 Faraz32123 self-assigned this May 8, 2024
DawoudSheraz
DawoudSheraz reviewed May 8, 2024
View reviewed changes
Copy link

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. I am constantly getting Socket timeout during nodejs-requirements layer. I will retry later. Once verified, I will give 👍🏽

@Danyal-Faheem
Copy link
Contributor

Should we not update these details here

tutor-credentials/tutorcredentials/templates/credentials/build/credentials/Dockerfile

Line 4 in ad4d593

LABEL maintainer="Lawrence McDaniel <lpm0073@gmail.com>"

as per this commit?

@Faraz32123
Copy link
Collaborator Author

Should we not update these details here

tutor-credentials/tutorcredentials/templates/credentials/build/credentials/Dockerfile

Line 4 in ad4d593

LABEL maintainer="Lawrence McDaniel <lpm0073@gmail.com>"

as per this commit?

Lawrence McDaniel was the author of this plugin. As we are already mentioning author and maintainer in setup.py, I'll update the Dockerfile.
@Danyal-Faheem thanks for pointing out.

Muhammad Faraz Maqsood and others added 2 commits May 8, 2024 17:53
remove label from dockerfile
380cbc1 
as the maintainer's and author's information already mentioned in the setup.py
@Danyal-Faheem
ci: temporarily skip building on arm64
51403c6 
As the upstream credentials repo seems to be breaking on arm64
and they are skipping arm64 builds as well due to the didkit
package dependency not available on arm64 yet
DawoudSheraz
DawoudSheraz approved these changes May 14, 2024
View reviewed changes
Copy link

@DawoudSheraz DawoudSheraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not re-tried it but going to give a 👍🏽 as I understand Danyal has been testing it out.

Please use "Squash and Merge" when merging this. Thanks

@Faraz32123 Faraz32123 merged commit b883636 into overhangio:nightly May 14, 2024
@Faraz32123 Faraz32123 deleted the enhancement/python_upgrade_to_v3.11.9 branch May 14, 2024 05:47
@Faraz32123 Faraz32123 mentioned this pull request May 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Danyal-Faheem Danyal-Faheem Danyal-Faheem approved these changes

@DawoudSheraz DawoudSheraz DawoudSheraz approved these changes

Assignees

@Faraz32123 Faraz32123

Labels
None yet
Projects
Tutor project management
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Faraz32123 @Danyal-Faheem @DawoudSheraz