Skip to content

Make created cache dir mask as option and default to 0777 #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcg-web merged 2 commits into from
Jan 13, 2019
Merged

Make created cache dir mask as option and default to 0777 #26

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc9128f
Make created cache dir maskas option and default to 0777
Vincz Dec 26, 2018
42f7763
Update src/Generator/AbstractTypeGenerator.php
mcg-web Jan 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/Generator/AbstractTypeGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,13 +62,19 @@ function (%s) <closureUseStatements>{
*/
private $expressionLanguage;

/**
* @var int
*/
protected $cacheDirMask;
Copy link
Contributor

@mcg-web mcg-web Dec 27, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the value can be set using construct making this private in a first place could ease maintenance.

Suggested change
protected $cacheDirMask;
private $cacheDirMask;


/**
* @param string $classNamespace The namespace to use for the classes.
* @param string[]|string $skeletonDirs
*/
public function __construct($classNamespace = self::DEFAULT_CLASS_NAMESPACE, $skeletonDirs = [])
public function __construct($classNamespace = self::DEFAULT_CLASS_NAMESPACE, $skeletonDirs = [], $cacheDirMask = 0775)
{
parent::__construct($classNamespace, $skeletonDirs);
$this->cacheDirMask = $cacheDirMask;
}

public function setExpressionLanguage(ExpressionLanguage $expressionLanguage = null)
Expand Down Expand Up @@ -361,7 +367,7 @@ public function generateClass(array $config, $outputDirectory, $mode = false)
if ($mode & self::MODE_WRITE) {
$dir = dirname($path);
if (!is_dir($dir)) {
mkdir($dir, 0775, true);
mkdir($dir, $this->cacheDirMask, true);
}
if (($mode & self::MODE_OVERRIDE) || !file_exists($path)) {
file_put_contents($path, $code);
Expand Down