Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix warnings during bun run publish-layer #5419

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

nangchan
Copy link
Contributor

When running bun run publish-layer the following warnings displayed:

$ bun scripts/publish-layer.ts
101 |     async load() {
102 |         this.type = this.options.type || 'core';
103 |         this.tag = this.options.tag;
104 |         const root = await findRoot(this.options.name, this.options.root);
105 |         if (!root)
106 |             throw new Error(`could not find package.json with ${(0, util_1.inspect)(this.options)}`);
                      ^
warn: could not find package.json with { type: 'dev',

What does this PR do?

Added missing package @oclif/plugin-plugins to resolved warning

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

  • I ran bun run publish-layer and verified layer was published

- add missing package @oclif/plugin-plugins to resolved warning: could not find package.json with { type: 'dev',
@Electroid
Copy link
Contributor

Thanks for fixing this!

@Electroid Electroid merged commit 23b1276 into oven-sh:main Sep 14, 2023
paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
- add missing package @oclif/plugin-plugins to resolved warning: could not find package.json with { type: 'dev',
@nangchan
Copy link
Contributor Author

Thanks for fixing this!

Thanks for the merge.

@nangchan nangchan deleted the fix-publish-layer branch September 18, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants