New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async-ify all node:fs functions #5360

Merged

Jarred-Sumner merged 4 commits into main from jarred/promisify-all-the-things

Sep 15, 2023

Collaborator

Jarred-Sumner commented Sep 14, 2023 •

edited

Loading

What does this PR do?

This makes all node:fs functions which have an async or promise version and makes them actually async in the threadpool

this is not super optimized on linux. it really should use io_uring when supported. It does not. It does the slow thing.

I suspect this will fix #4743 but needs testing

How did you verify your code works?

Needs tests for everything


          async all node:fs functions

16b5b1b

Contributor

github-actions bot commented Sep 14, 2023

❌ @Jarred-Sumner 14 files with test failures on linux-x64:

test/cli/install/bun-add.test.ts
test/cli/install/bun-install.test.ts
test/cli/install/bun-link.test.ts
test/cli/install/bun-pm.test.ts
test/cli/install/bun-remove.test.ts
test/cli/install/bun-run.test.ts
test/cli/install/bun-update.test.ts
test/cli/install/bunx.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/async_hooks/AsyncLocalStorage.test.ts
test/js/node/fs/cp.test.ts
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/third_party/webpack/webpack.test.ts

View test output

^{#780755e8bfc3266a57ff2838e35a70b8b707e23e}

Contributor

github-actions bot commented Sep 14, 2023

❌ @Jarred-Sumner 14 files with test failures on linux-x64-baseline:

test/cli/install/bun-add.test.ts
test/cli/install/bun-install.test.ts
test/cli/install/bun-link.test.ts
test/cli/install/bun-pm.test.ts
test/cli/install/bun-remove.test.ts
test/cli/install/bun-run.test.ts
test/cli/install/bun-update.test.ts
test/cli/install/bunx.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/async_hooks/AsyncLocalStorage.test.ts
test/js/node/fs/cp.test.ts
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/third_party/webpack/webpack.test.ts

View test output

^{#780755e8bfc3266a57ff2838e35a70b8b707e23e}

Contributor

github-actions bot commented Sep 14, 2023

❌ @Jarred-Sumner 15 files with test failures on bun-darwin-aarch64:

test/bundler/bundler_naming.test.ts
test/cli/install/bun-add.test.ts
test/cli/install/bun-install.test.ts
test/cli/install/bun-link.test.ts
test/cli/install/bun-pm.test.ts
test/cli/install/bun-remove.test.ts
test/cli/install/bun-run.test.ts
test/cli/install/bun-update.test.ts
test/cli/install/bunx.test.ts
test/js/bun/test/test-test.test.ts
test/js/node/async_hooks/AsyncLocalStorage.test.ts
test/js/node/fs/cp.test.ts
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/third_party/webpack/webpack.test.ts

View test output

^{#780755e8bfc3266a57ff2838e35a70b8b707e23e}

Contributor

github-actions bot commented Sep 14, 2023

❌ @Jarred-Sumner 18 files with test failures on bun-darwin-x64-baseline:

test/bundler/bundler_compile.test.ts
test/cli/install/bun-add.test.ts
test/cli/install/bun-install.test.ts
test/cli/install/bun-link.test.ts
test/cli/install/bun-pm.test.ts
test/cli/install/bun-remove.test.ts
test/cli/install/bun-run.test.ts
test/cli/install/bun-update.test.ts
test/cli/install/bunx.test.ts
test/js/bun/spawn/spawn.test.ts
test/js/bun/sqlite/sqlite.test.js
test/js/bun/test/test-test.test.ts
test/js/node/async_hooks/AsyncLocalStorage.test.ts
test/js/node/fs/cp.test.ts
test/js/node/fs/fs.test.ts
test/js/node/watch/fs.watch.test.ts
test/js/third_party/webpack/webpack.test.ts
test/js/web/timers/setTimeout.test.js

View test output

^{#780755e8bfc3266a57ff2838e35a70b8b707e23e}

Jarred-Sumner added 2 commits

September 14, 2023 16:27


          draw the rest of the owl

31ac697


          LLVM & Clang 16

7c0d598

Jarred-Sumner marked this pull request as ready for review

September 15, 2023 01:44


          Merge branch 'main' into jarred/promisify-all-the-things

538eb40

Jarred-Sumner merged commit ced69d3 into main

15 of 20 checks passed

Jarred-Sumner deleted the jarred/promisify-all-the-things branch

September 15, 2023 04:26

Jarred-Sumner mentioned this pull request

bun --bun run dev fails with nuxt #4743

Closed

paperdave pushed a commit to SuperAuguste/bun that referenced this pull request


          async-ify all node:fs functions (oven-sh#5360)

ef9d9dc

* async all node:fs functions

* draw the rest of the owl

* LLVM & Clang 16

---------

Co-authored-by: Jarred Sumner <709451+Jarred-Sumner@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet