Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runtime): emit node:net connect error event vs throw #5336

Merged
merged 5 commits into from
Sep 15, 2023

Conversation

paperdave
Copy link
Member

What does this PR do?

does not fully fix pm2 but it doesnt error on startup anymore

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

@github-actions
Copy link
Contributor

@paperdave 3 files with test failures on bun-darwin-aarch64:

  • test/bundler/bundler_minify.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts

View test output

#e4c5bd8cd29477b70ed050601adf9d7d939b9154

@paperdave paperdave marked this pull request as ready for review September 14, 2023 04:27
@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

✅ test failures on linux-x64 have been resolved.

#70d44647ab00d3d8459ff3412d9c54839090db9d

@github-actions
Copy link
Contributor

github-actions bot commented Sep 14, 2023

@paperdave 1 files with test failures on linux-x64-baseline:

  • test/js/web/fetch/fetch-gzip.test.ts

View test output

#70d44647ab00d3d8459ff3412d9c54839090db9d

@github-actions
Copy link
Contributor

@paperdave 5 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#70d44647ab00d3d8459ff3412d9c54839090db9d

@Jarred-Sumner Jarred-Sumner merged commit e8d58f2 into main Sep 15, 2023
16 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dave/fix_pm2 branch September 15, 2023 00:30
paperdave added a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
)

* fix(runtime): emit `node:net` connect error event vs throw

* oops

* finally

* ok

* we are good
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants