Remove the ability to configure lockfile location. #5335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enabling configuration of lockfile location at the global config level means that the lockfile isn't guaranteed consistent across a team. Currently, the only "safe" (read: assured consistent) way to use
bun
with multiple contributor teams requires setting that value in the localbunfig.toml
.Splitting the two values from each other enables a configuration where you can’t read after writing.
env
priority is "correct" forBUN_CONFIG_LOCKFILE_SAVE_PATH
but I don't feel like it should exist. It isn't used in the test suite, makes shared configuration impossible, and appears semi-arbitrarily added two years ago in December 2021.--lockfile
introduces the same problem, and since it is per-execution, is extremely difficult to ensure consistency. It also gets removed.Approach notes:
lockfile_path
is now a static string.Closes #5259