Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This makes
--watch
not wait on the event loop. So if you have slow code that is running, the script restarts immediately instead of waits. While we do use CLOEXEC, we also go ahead and manually track open listening sockets for the HTTP server and close them all before reloading the process. I think that was the original reason why we didn't do this - because you could end up in situations where the OS would route it to a stale HTTP server listening.How did you verify your code works?
Manual + existing tests