Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decode regex if needed #5167

Merged
merged 4 commits into from
Sep 13, 2023
Merged

decode regex if needed #5167

merged 4 commits into from
Sep 13, 2023

Conversation

dylan-conway
Copy link
Member

What does this PR do?

fixes #5132

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

added test and tested manually.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

@dylan-conway 3 files with test failures on bun-darwin-aarch64:

  • test/js/bun/spawn/spawn.test.ts
  • test/js/bun/test/test-test.test.ts
  • test/js/node/watch/fs.watch.test.ts

View test output

#5c467060976df3c3e8c3345a10c25a8880e4a755

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

@dylan-conway 1 files with test failures on linux-x64-baseline:

  • test/js/web/fetch/fetch-gzip.test.ts

View test output

#5c467060976df3c3e8c3345a10c25a8880e4a755

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

✅ test failures on linux-x64 have been resolved.

#5c467060976df3c3e8c3345a10c25a8880e4a755

@github-actions
Copy link
Contributor

github-actions bot commented Sep 12, 2023

@dylan-conway 4 files with test failures on bun-darwin-x64-baseline:

  • test/js/bun/sqlite/sqlite.test.js
  • test/js/node/fs/fs.test.ts
  • test/js/third_party/webpack/webpack.test.ts
  • test/js/web/timers/setTimeout.test.js

View test output

#5c467060976df3c3e8c3345a10c25a8880e4a755

src/js_ast.zig Outdated Show resolved Hide resolved
@Jarred-Sumner Jarred-Sumner merged commit 32664df into main Sep 13, 2023
16 of 20 checks passed
@Jarred-Sumner Jarred-Sumner deleted the dylan/decode-regex-if-needed branch September 13, 2023 08:26
Jarred-Sumner added a commit that referenced this pull request Sep 15, 2023
Jarred-Sumner added a commit that referenced this pull request Sep 15, 2023
paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
* decode regex if non-ascii

* make it comptime

* add test

* use `bun.BabyList(u16)`
paperdave pushed a commit to SuperAuguste/bun that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace string with regular expression got wrong output
2 participants